-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47198/#review134450
-----------------------------------------------------------




include/mesos/docker/v1.proto (lines 53 - 56)
<https://reviews.apache.org/r/47198/#comment199252>

    Mind pulling this to the top level?
    ```
    spec::v1::Label
    ```



include/mesos/docker/v1.proto (lines 58 - 64)
<https://reviews.apache.org/r/47198/#comment199253>

    I would mention that we cannot use `Labels` here because otherwise, 
json->protobuf parsing will fail. `labels` is manually set during parsing.


- Jie Yu


On May 13, 2016, 8:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47198/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 8:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-5272
>     https://issues.apache.org/jira/browse/MESOS-5272
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added labels to docker v1 spec config.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/v1.proto ff18f8cadfce3315467f194d50d3469fa839f686 
> 
> Diff: https://reviews.apache.org/r/47198/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to