----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/#review134504 -----------------------------------------------------------
Ship it! Ship It! - Kapil Arya On May 10, 2016, 10:13 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47215/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 10:13 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Bugs: MESOS-5350 > https://issues.apache.org/jira/browse/MESOS-5350 > > > Repository: mesos > > > Description > ------- > > This changes how we override the `CommandInfo` when launching a > dockerized executor; from `shell == true` to `shell = false`. > This means that flags are now passed directly rather than as > a long string. > > i.e. > From: 'mesos-docker-executor --foo="bar" --some="thing"' > To: [ 'mesos-docker-executor', '--foo=bar', '--some=thing' ] > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 > > Diff: https://reviews.apache.org/r/47215/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
