> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 17-20 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line17> > > > > newline for each.
Can you please take a look at https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md to see the output of this? What I want is that I hope that I can list all of the driver backends as `including Convoy plugin, Flocker plugin, GlusterFS plugin, REX-Ray plugin etc.` > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, line 30 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line30> > > > > s/docker volume driver isolator/ docker volume isolator/g I do not found I have this in the document ;-) > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 33-40 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line33> > > > > Merge together and rephase. I think that diving those to two parts may be better and seems difficult to merge those two part. > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, line 42 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line42> > > > > Move this below when introducing `container_path`: > > > > The docker volume isolator supports tasks with/without rootfs: > > with rootfs v.s. without rootfs > > absolute path v.s. relative path I was clarifying this part in line 198, hope it is OK. > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 45-52 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line45> > > > > kill this. Here I want to list an e2e use case just like what we did for https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#framework-requests-ip-address-for-containers here. > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 54-75 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line54> > > > > kill this. > > > > Generally, we may not need to explain the implementation in detail. > > Let's just explain the diagram and mention the recoverablity in one > > sentence. Can we take this as the explanation for the diagram? I was following this document as a reference https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#network-virtualizer-assigns-ip-address-to-the-container-and-isolates-it , comments? > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 120-187 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line120> > > > > let's just pick out related message fields and filter out all comments. Except `host_path`, all of other fields are needed, so I suggest that we keep current protobuf. > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 216-288 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line216> > > > > we dont need this if we explain ContainerInfo.Volumes above. I think that it is better put an example here to show how to use the protobuf, this can make the framework developer more clear for how to use it, and I was following the same way as https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#enabling-frameworks-for-ip-per-container-capability here > On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 79-80 > > <https://reviews.apache.org/r/47511/diff/4/?file=1388951#file1388951line79> > > > > could we rephase? Updated a bit. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review134461 ----------------------------------------------------------- On 五月 24, 2016, 4:11 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47511/ > ----------------------------------------------------------- > > (Updated 五月 24, 2016, 4:11 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5216 > https://issues.apache.org/jira/browse/MESOS-5216 > > > Repository: mesos > > > Description > ------- > > Added documentation for `docker/volume` isolator. > > > Diffs > ----- > > docs/docker-volume-isolator.md PRE-CREATION > docs/images/docker-volume-isolator.png PRE-CREATION > > Diff: https://reviews.apache.org/r/47511/diff/ > > > Testing > ------- > > You can review the document here: > https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md > > > Thanks, > > Guangya Liu > >
