----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47402/#review134595 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_recovery_tests.cpp (line 876) <https://reviews.apache.org/r/47402/#comment199442> I think we did a sweep to use a single space before the comments. - Jie Yu On May 15, 2016, 8:06 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47402/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 8:06 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5380 > https://issues.apache.org/jira/browse/MESOS-5380 > > > Repository: mesos > > > Description > ------- > > If the agent restarts after handling killTask but before sending > shutdown message to the executor, we ensure the executor terminates. > > > Diffs > ----- > > src/slave/slave.cpp bea35e5f7e22ced32514706827b4331c956ee674 > src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 > src/tests/slave_tests.cpp 4b1cfbb9f8de0e60a8a2c1f48b78c62be9fbaa40 > > Diff: https://reviews.apache.org/r/47402/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
