> On May 14, 2016, 1:55 p.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 96 > > <https://reviews.apache.org/r/47360/diff/2/?file=1383410#file1383410line96> > > > > Can you please show more detail for `may take any value, or may be > > omitted.` > > > > a) In which condition can take any value if the framework did not > > provide a principal. > > b) In which condition the `principal` will be omitted if the framework > > did not provide a principal. > > > > Ditto for others.
I changed the text slightly to clarify my meaning. This text is saying that if frameworkInfo.principal is not provided, then in all cases disk.persistence.principal can take any value or can be left unset. Let me know if my changes don't make this any clearer! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/#review133272 ----------------------------------------------------------- On May 24, 2016, 10:09 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47360/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 10:09 p.m.) > > > Review request for mesos, Bernd Mathiske and Neil Conway. > > > Bugs: MESOS-5215 > https://issues.apache.org/jira/browse/MESOS-5215 > > > Repository: mesos > > > Description > ------- > > This patch updates the documentation of RESERVE and > CREATE operations, both via offer operations and > operator endpoints. Specifically, we clarify the > Mesos master's expectations for the values of the > `principal` fields found in `ReservationInfo` and > `DiskInfo.Persistence`. > > > Diffs > ----- > > docs/persistent-volume.md c13d79124f0b5ea2a715b4d2990fda4e06b2fb02 > docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f > > Diff: https://reviews.apache.org/r/47360/diff/ > > > Testing > ------- > > Viewed with the Mesos website container: > https://github.com/mesosphere/mesos-website-container > > > Thanks, > > Greg Mann > >
