----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/#review134663 -----------------------------------------------------------
src/docker/docker.cpp (lines 451 - 452) <https://reviews.apache.org/r/47577/#comment199519> we can rename these as we did the others: `stdout_fd` -> `_stdout`. src/files/files.cpp (lines 560 - 561) <https://reviews.apache.org/r/47577/#comment199520> Did we rename this to `PATH_SEPARATOR`? Does this need to be rebased? src/health-check/main.cpp (lines 278 - 317) <https://reviews.apache.org/r/47577/#comment199521> These changes are not relevant any more. I think this review needs to be rebased. src/logging/logging.cpp (line 203) <https://reviews.apache.org/r/47577/#comment199522> Indentation. Missing period. Don't need the parantheses, wrap with backticks instead. src/uri/fetcher.hpp (lines 42 - 48) <https://reviews.apache.org/r/47577/#comment199523> Not sure what's going on here. Add a comment? Is this still relevant? src/uri/fetcher.cpp (lines 49 - 52) <https://reviews.apache.org/r/47577/#comment199524> Can you reference this JIRA you created to add support for hadoop files? It seems you also need one for docker? src/zookeeper/group.cpp (line 659) <https://reviews.apache.org/r/47577/#comment199525> rebase. src/zookeeper/group.cpp (line 700) <https://reviews.apache.org/r/47577/#comment199526> rebase. - Joris Van Remoortere On May 19, 2016, 4:07 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47577/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 4:07 a.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Agent: Added minor changes to various .cpp files to support Windows. > > > Diffs > ----- > > src/docker/docker.cpp 19cf424dfd5748ae66a7023840aa2b0652e8f2c0 > src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 > src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 > src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 > src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 > src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566 > src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7 > src/uri/fetchers/copy.cpp 2180adfba1f33852d11069eed9d9bca72e2e3b6f > src/uri/fetchers/curl.cpp c4420623d718d87776f2eb8e13faf02ef5edb335 > src/zookeeper/group.cpp 01680899778e554af70b176db82498ca92b51b60 > > Diff: https://reviews.apache.org/r/47577/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
