----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/#review134676 -----------------------------------------------------------
Fix it, then Ship it! Thanks for catching this. src/sched/sched.cpp (line 1353) <https://reviews.apache.org/r/47804/#comment199536> Can you log the warning like we do in acceptOffers()? ``` if (!savedOffers.contains(offerId)) { LOG(WARNING) << "Attempting to decline an unknown offer << offerId; } savedOffers.erase(offerId); ``` - Vinod Kone On May 25, 2016, 12:51 a.m., Dario Rexin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47804/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 12:51 a.m.) > > > Review request for mesos. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-5449 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-5449 > > > Repository: mesos > > > Description > ------- > > MesosScheduler.declineOffers has been changed ~6 months ago to send a Decline > message instead of calling acceptOffers with an empty list of task infos. The > changed version of declineOffer however did not remove the offerId from the > savedOffers map, causing a memory leak. > > > Diffs > ----- > > src/sched/sched.cpp 9e55885 > > Diff: https://reviews.apache.org/r/47804/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dario Rexin > >
