----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/#review134859 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 1025 - 1032) <https://reviews.apache.org/r/47149/#comment199793> Instead of using lambda::bind, you should use `defer(self(), &Self::_launch, ...)`. The reason is because `f` might have a longer life cycle than `this`. src/slave/containerizer/docker.cpp (line 1034) <https://reviews.apache.org/r/47149/#comment199822> 2 lines apart here. src/slave/containerizer/docker.cpp (line 1042) <https://reviews.apache.org/r/47149/#comment199824> What if containerizer->destroy is called between `_launch` and `launch`? Do you need to check if `containers_.contains(containerId)` and return a failure if it's no longer there? - Jie Yu On May 11, 2016, 2:13 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47149/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 2:13 a.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Bugs: MESOS-5350 > https://issues.apache.org/jira/browse/MESOS-5350 > > > Repository: mesos > > > Description > ------- > > This prepares the `::launch` method for an asynchronous hook. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fac26a239e9981e5b1c2f2f90b52785819492c2a > src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 > > Diff: https://reviews.apache.org/r/47149/diff/ > > > Testing > ------- > > sudo make check (CentOS 7) > > > Thanks, > > Joseph Wu > >
