> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 286-288 > > <https://reviews.apache.org/r/47576/diff/1/?file=1387609#file1387609line286> > > > > Quick comment saying that the network isolator is currently not > > supported on windows. > > > > Can you add (and reference in the comment) a JIRA to update the > > autoconf to catch this case during configure?
Why do we need to catch this in the AC builds? Mesos doesn't build on Windows in AC. > On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/launcher.hpp, lines 118-119 > > <https://reviews.apache.org/r/47576/diff/1/?file=1387610#file1387610line118> > > > > Is this the only difference? > > It would be great if we could clearly identify the differences, and > > reference a JIRA here to keep track of them. I'm not sure how to capture this. There are too many differences to name. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review134662 ----------------------------------------------------------- On May 19, 2016, 2:47 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47576/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 2:47 a.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, > MESOS-3681, MESOS-3682, and MESOS-3684 > https://issues.apache.org/jira/browse/MESOS-3617 > https://issues.apache.org/jira/browse/MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3619 > https://issues.apache.org/jira/browse/MESOS-3622 > https://issues.apache.org/jira/browse/MESOS-3623 > https://issues.apache.org/jira/browse/MESOS-3624 > https://issues.apache.org/jira/browse/MESOS-3681 > https://issues.apache.org/jira/browse/MESOS-3682 > https://issues.apache.org/jira/browse/MESOS-3684 > > > Repository: mesos > > > Description > ------- > > Agent: Add Windows support to the containerizer. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 > src/slave/containerizer/external_containerizer.cpp > cf4384cce44172a028c890f52f71ceb8ae109383 > src/slave/containerizer/mesos/containerizer.cpp > 75e5a32a3e70ec60a6800e21a621673184ea0956 > src/slave/containerizer/mesos/launcher.hpp > 5977c30c0aacc569019f7b34bb0c6577823ec887 > src/slave/containerizer/mesos/launcher.cpp > a5c8c31b72773d0bd10b9d02675a01f1d641d41c > > Diff: https://reviews.apache.org/r/47576/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
