----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review135019 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 307) <https://reviews.apache.org/r/45377/#comment200005> "The volume dirver is not specified for volume '" ... src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 308) <https://reviews.apache.org/r/45377/#comment200006> Usually we are trying not starting any second line msg with a space " ". - Gilbert Song On May 25, 2016, 6:34 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45377/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 6:34 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5354 > https://issues.apache.org/jira/browse/MESOS-5354 > > > Repository: mesos > > > Description > ------- > > Made "driver" as optional for DockerVolume. > > > Diffs > ----- > > include/mesos/mesos.proto f666535bcaf8ec263eada7e0cf925d8eb3836ba8 > include/mesos/v1/mesos.proto ce187e71003f82852a8addadfdbc7c6f82dfaa2b > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 8ab2cf39a6bc3dd841b51639942b3e5258b7292e > > Diff: https://reviews.apache.org/r/45377/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
