> On May 26, 2016, 11:54 a.m., Adam B wrote: > > src/files/files.cpp, lines 265-266 > > <https://reviews.apache.org/r/47794/diff/3/?file=1395065#file1395065line265> > > > > Mesos doesn't do it now, but nothing prevents us from attaching "/", > > which would be cleaned to "". Is this ok? Should we at least have a check > > for attaching root/empty path? Let's add a unit test (can be a separate > > patch).
Added jira https://issues.apache.org/jira/browse/MESOS-5463 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/#review134949 ----------------------------------------------------------- On May 26, 2016, 6:05 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47794/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 6:05 p.m.) > > > Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, > and Vinod Kone. > > > Bugs: MESOS-5153 > https://issues.apache.org/jira/browse/MESOS-5153 > > > Repository: mesos > > > Description > ------- > > Adds an optional parameter to the `mesos::internal::Files::attach()` > method. The type of this parameter is a callable object which returns > a future to a boolean and takes as parameter an optional string > representing a principal name. > > The parameter is called, if set, whenever one of the routed endpoints > of the `Files` object is accessed through HTTP. If the callable object > returns a false boolean, then processing of the request is aborted > and a `403 Forbidden` response is returned. > > > Diffs > ----- > > src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b > src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 > src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd > > Diff: https://reviews.apache.org/r/47794/diff/ > > > Testing > ------- > > On OSX: > `make check` > > > Thanks, > > Alexander Rojas > >
