----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review135132 -----------------------------------------------------------
Patch looks great! Reviews applied: [47082] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 26, 2016, 11:56 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47082/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 11:56 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5143 > https://issues.apache.org/jira/browse/MESOS-5143 > > > Repository: mesos > > > Description > ------- > > When a slave is removed, master sends a LostSlaveMessage to affected > frameworks only (instead of all registered frameworks). An affected > framework is a framework which satisfied one or more conditions of > the following: > > 1. There are running tasks on this slave belonging to the framework. > 2. There are pending tasks on this slave belonging to the framework. > 3. Reserved resources on the slave have a matching role with the > role of the framework. > 4. There are pending offers or pending inverse offers from this slave > for the framework. > > > Diffs > ----- > > src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 > src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b > src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 > > Diff: https://reviews.apache.org/r/47082/diff/ > > > Testing > ------- > > All existing and modified tests passed. > > > Thanks, > > Anindya Sinha > >