> On May 24, 2016, 11:51 p.m., Joris Van Remoortere wrote: > > 3rdparty/stout/include/stout/windows.hpp, lines 420-431 > > <https://reviews.apache.org/r/47602/diff/1/?file=1388158#file1388158line420> > > > > Can you provide a little more context for these? > > I see what you're doing, not sure of why or what it impacts. > > Thanks!
REGISTERING, REGISTERED as mesos-angent state but are define in NetBios header. This code should just undef them, amek the in is not necessary. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/#review134665 ----------------------------------------------------------- On May 19, 2016, 4:08 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47602/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 4:08 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout:[1/2] Added Windows support for folder `launcher/`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows.hpp > a7a59e78575e1456b4e14d18ac97f51dd23d794e > > Diff: https://reviews.apache.org/r/47602/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
