----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47522/#review135200 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 1448) <https://reviews.apache.org/r/47522/#comment200238> As we have "volume and subsequent statements in a scope block above, can we have the same here, please? src/tests/persistent_volume_tests.cpp (line 1665) <https://reviews.apache.org/r/47522/#comment200241> Same here: above block around "volume" with braces, this one without. - Bernd Mathiske On May 26, 2016, 11:25 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47522/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 11:25 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > This patch adds a creator principal to the > persistent volumes used in the PersistentVolumeTests. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > d246f35046fff469b847c908de2b305ae629212f > > Diff: https://reviews.apache.org/r/47522/diff/ > > > Testing > ------- > > `make check` was used to test on OSX at the end of this review chain. > > > Thanks, > > Greg Mann > >
