> On May 27, 2016, 9:36 a.m., Bernd Mathiske wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1011 > > <https://reviews.apache.org/r/47521/diff/2/?file=1396090#file1396090line1011> > > > > In the above case, this part is within the scope block, here it is not. > > Please move the opening curly brace up.
The volume is left out of the scope here because it gets used much later in the test. If we scoped it, we would have to extend the scope nearly to the end of the test. What do you think? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/#review135194 ----------------------------------------------------------- On May 27, 2016, 5:37 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47521/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 5:37 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > A creator principal is added to the persistent volumes > used in the PersistentVolumeEndpointsTests. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > a57461d881b2bf0175f83b50b0a46167acd5bd3e > > Diff: https://reviews.apache.org/r/47521/diff/ > > > Testing > ------- > > `make check` was used to test on OSX. > > > Thanks, > > Greg Mann > >
