> On May 27, 2016, 2:21 p.m., James Peach wrote: > > I guess not many people are using this, but consider whether you should > > keep the old name at well for backwards compatibility.
This is pre-release feature so I think we shuold be fine if this rename lands before 0.29.0 is cut. For /r/47895/ we should totally maintain backwards-compatibility but for this I don't think it's expected. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47894/#review135326 ----------------------------------------------------------- On May 26, 2016, 8:05 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47894/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 8:05 a.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Bugs: MESOS-5394 > https://issues.apache.org/jira/browse/MESOS-5394 > > > Repository: mesos > > > Description > ------- > > Renamed 'xfs/disk' isolator to 'disk/xfs'. > > > Diffs > ----- > > CHANGELOG d9b155dbb3beffc782de58b2a9478fd1554184a6 > docs/mesos-containerizer.md 22dffe00b315148f4ca158b0b606f254b9ee53c2 > src/slave/containerizer/mesos/containerizer.cpp > 75e5a32a3e70ec60a6800e21a621673184ea0956 > src/tests/containerizer/xfs_quota_tests.cpp > ce16006f1a370b9b48837abee729669b84a885a2 > > Diff: https://reviews.apache.org/r/47894/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
