----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135335 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp (line 141) <https://reviews.apache.org/r/47891/#comment200360> command is required in ExecutorInfo. src/authorizer/local/authorizer.cpp (line 152) <https://reviews.apache.org/r/47891/#comment200361> Note that at least with the other Actions non-existent `value` implies `ANY` - Joerg Schad On May 27, 2016, 9:51 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47891/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 9:51 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Michael > Park. > > > Bugs: MESOS-5459 > https://issues.apache.org/jira/browse/MESOS-5459 > > > Repository: mesos > > > Description > ------- > > Authorization requests for RUN_TASK actions can pass `SOME` > authorization object either in a `FrameworkInfo` holding a user, or a > `TaskInfo` with optionally a `CommandInfo` which can optionally hold a > user. If either of these fields is set it will be used as the object; > otherwise an `ANY` type authorization object will be created. > > `RUN_TASK` aliases `RUN_TASK_WITH_USER` which becomes deprecated with > 0.29. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 3ff67858a99915e0215f3ffb9966f9ac4a3fba8c > src/authorizer/local/authorizer.cpp > 7ddb323df09a9b0ea46c6f9543c4af059d184308 > src/master/master.cpp 6442762c9fdfa368d5d9d7cd43b97f5addaf7f17 > src/tests/authorization_tests.cpp 54bfb46a807677f4a4a2bb88dcb78a358cf5121a > > Diff: https://reviews.apache.org/r/47891/diff/ > > > Testing > ------- > > Tested on a range of Linux configurations on internal CI. > > > Thanks, > > Benjamin Bannier > >
