> On May 27, 2016, 11:17 p.m., Jie Yu wrote: > > HUm, i got confused. Why this patch has so many new additions? Do you need > > a rebase? It's hard to review this one. > > Guangya Liu wrote: > This patch is splitting the test case of > `DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes` to two cases: > one for absolute path and the other is for relative path. > > Just spliting this command > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_volume_isolator_tests.cpp#L293-L294 > to two test cases. > > The reason that I need to split is that I did not found a good wayt to > enable one `command` with `shell` as false to execute two commands. Comments?
OK, make sense. It'll be helpful to say that in the description of this review. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/#review135345 ----------------------------------------------------------- On May 20, 2016, 12:20 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46428/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 12:20 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5351 > https://issues.apache.org/jira/browse/MESOS-5351 > > > Repository: mesos > > > Description > ------- > > Fixed the broken Docker Volume Rootfs Test on Centos7. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 > > Diff: https://reviews.apache.org/r/46428/diff/ > > > Testing > ------- > > make > make check > > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from DockerVolumeIsolatorTest > [ RUN ] > DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithAbsolutePathVolume > [ OK ] > DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithAbsolutePathVolume > (1732 ms) > [ RUN ] > DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithRelativeVolume > [ OK ] > DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithRelativeVolume > (1708 ms) > [----------] 2 tests from DockerVolumeIsolatorTest (3451 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (3460 ms total) > [ PASSED ] 2 tests. > [root@mesos-24 build]# cat /etc/*release > CentOS Linux release 7.2.1511 (Core) > NAME="CentOS Linux" > VERSION="7 (Core)" > ID="centos" > ID_LIKE="rhel fedora" > VERSION_ID="7" > PRETTY_NAME="CentOS Linux 7 (Core)" > ANSI_COLOR="0;31" > CPE_NAME="cpe:/o:centos:centos:7" > HOME_URL="https://www.centos.org/"; > BUG_REPORT_URL="https://bugs.centos.org/"; > > CENTOS_MANTISBT_PROJECT="CentOS-7" > CENTOS_MANTISBT_PROJECT_VERSION="7" > REDHAT_SUPPORT_PRODUCT="centos" > REDHAT_SUPPORT_PRODUCT_VERSION="7" > > CentOS Linux release 7.2.1511 (Core) > CentOS Linux release 7.2.1511 (Core) > [root@mesos-24 build]# > > > Thanks, > > Guangya Liu > >
