----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47905/#review135515 -----------------------------------------------------------
Fix it, then Ship it! src/tests/module_tests.cpp (lines 17 - 18) <https://reviews.apache.org/r/47905/#comment200504> Alphabetize plz. src/tests/module_tests.cpp (line 26) <https://reviews.apache.org/r/47905/#comment200505> Insert blank line plz. src/tests/module_tests.cpp (line 30) <https://reviews.apache.org/r/47905/#comment200506> Missing? ``` #include <stout/path.hpp> ``` ``` #include <stout/stringify.hpp> ``` - Till Toenshoff On May 26, 2016, 5:57 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47905/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 5:57 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Added test for --modules_dir flag. > > > Diffs > ----- > > src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737 > > Diff: https://reviews.apache.org/r/47905/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
