> On May 30, 2016, 9:10 p.m., Vinod Kone wrote: > > site/Dockerfile, line 4 > > <https://reviews.apache.org/r/48051/diff/1/?file=1401325#file1401325line4> > > > > what is this additional port for?
It's used by middleman to provide page autoreload when changes to files are deteted. In [Gemfile](https://github.com/apache/mesos/blob/master/site/Gemfile#L4]) `middleman-livereload` gem is declared but without this port it's unusable and site produce errors in console. We can either expose this port or remove `middleman-livereload` gem. - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135545 ----------------------------------------------------------- On May 30, 2016, 9:21 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48051/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 9:21 p.m.) > > > Review request for mesos, haosdent huang, Kevin Klues, Neil Conway, and Vinod > Kone. > > > Bugs: MESOS-5431 > https://issues.apache.org/jira/browse/MESOS-5431 > > > Repository: mesos > > > Description > ------- > > Expose livereload port in site docker. > > > Diffs > ----- > > site/Dockerfile 80e28e96be53909a8c3c1eb3c05dbbc7e698a5a5 > site/README.md 91bfd5fff16c7848431bdfc9206f42d18e102ace > > Diff: https://reviews.apache.org/r/48051/diff/ > > > Testing > ------- > > Exposing port 35729 is necessary to enable livereload > provided by `middleman-livereload` gem. > > > Thanks, > > Tomasz Janiszewski > >
