----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/#review135574 -----------------------------------------------------------
src/exec/exec.cpp (line 652) <https://reviews.apache.org/r/47873/#comment200598> I replaced `last` with `buf` src/exec/exec.cpp (lines 655 - 656) <https://reviews.apache.org/r/47873/#comment200597> Just to minimize potential behavioral changes I'll pull out the buffer size and only change it on Windows. I've also changed the buf parameter to be `NULL` as referenced in your comment. - Joris Van Remoortere On May 30, 2016, 10:39 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47873/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 10:39 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Microsoft MSVCCRT requires a value for the buffer size. > > > Diffs > ----- > > src/exec/exec.cpp 69a1fb256fe3005e814833ecac5a5a642b585510 > > Diff: https://reviews.apache.org/r/47873/diff/ > > > Testing > ------- > > Windows: build/test > > > Thanks, > > Daniel Pravat > >
