----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/#review135580 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/posix/os.hpp (line 448) <https://reviews.apache.org/r/47942/#comment200603> 2 blank lines between functions. 3rdparty/stout/include/stout/posix/os.hpp (line 450) <https://reviews.apache.org/r/47942/#comment200602> brace goes on next line. 3rdparty/stout/include/stout/posix/os.hpp (line 452) <https://reviews.apache.org/r/47942/#comment200601> brace goes on previous line. 3rdparty/stout/include/stout/posix/os.hpp (line 453) <https://reviews.apache.org/r/47942/#comment200600> indentation. 3rdparty/stout/include/stout/windows/os.hpp (line 753) <https://reviews.apache.org/r/47942/#comment200604> brace goes on new line. 3rdparty/stout/include/stout/windows/os.hpp (lines 754 - 777) <https://reviews.apache.org/r/47942/#comment200605> indentation 3rdparty/stout/include/stout/windows/os.hpp (lines 765 - 766) <https://reviews.apache.org/r/47942/#comment200606> wrapping. 3rdparty/stout/include/stout/windows/os.hpp (line 768) <https://reviews.apache.org/r/47942/#comment200607> wrapping. 3rdparty/stout/include/stout/windows/os.hpp (line 769) <https://reviews.apache.org/r/47942/#comment200608> no need for trailing space inside `if` expression 3rdparty/stout/include/stout/windows/os.hpp (line 773) <https://reviews.apache.org/r/47942/#comment200609> no need for trailing space inside `if` expression 3rdparty/stout/include/stout/windows/os.hpp (lines 790 - 791) <https://reviews.apache.org/r/47942/#comment200610> This should be a comment generalized to a library. - Joris Van Remoortere On May 29, 2016, 7:09 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47942/ > ----------------------------------------------------------- > > (Updated May 29, 2016, 7:09 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Added pipe support functions. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > f08604cdd331f0f4394f64ec06a8461f1df6c888 > 3rdparty/stout/include/stout/windows/os.hpp > 1363be1d4010028d4fc50242c80d91c0dd53e14c > > Diff: https://reviews.apache.org/r/47942/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/run > > > Thanks, > > Alex Clemmer > >
