----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/#review135582 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/windows/shell.hpp (line 24) <https://reviews.apache.org/r/47943/#comment200613> We can't do this in an `.hpp` 3rdparty/stout/include/stout/os/windows/shell.hpp (line 116) <https://reviews.apache.org/r/47943/#comment200614> typo 3rdparty/stout/include/stout/os/windows/shell.hpp (lines 125 - 127) <https://reviews.apache.org/r/47943/#comment200615> we can re-indent these bullets. - Joris Van Remoortere On May 31, 2016, 3:31 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47943/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 3:31 a.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout: Implemented `shell.hpp` on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/shell.hpp > ea6ae5ab981f422993085e63543d184a8e41524d > > Diff: https://reviews.apache.org/r/47943/diff/ > > > Testing > ------- > > Windows: buil/run > > > Thanks, > > Alex Clemmer > >
