> On May 31, 2016, 5:08 a.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1233-1239 > > <https://reviews.apache.org/r/47576/diff/11/?file=1401297#file1401297line1233> > > > > Do these get stored correctly since `launchFlags.pipe_xxx` is an int? > > This same problem applies for when we write them.
This seems to be working because the `HANDLE`s have low values in basic environments. We'll need to find a more robust solution to this beyond the MVP. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review135590 ----------------------------------------------------------- On May 30, 2016, 4:55 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47576/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 4:55 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, > MESOS-3681, MESOS-3682, and MESOS-3684 > https://issues.apache.org/jira/browse/MESOS-3617 > https://issues.apache.org/jira/browse/MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3619 > https://issues.apache.org/jira/browse/MESOS-3622 > https://issues.apache.org/jira/browse/MESOS-3623 > https://issues.apache.org/jira/browse/MESOS-3624 > https://issues.apache.org/jira/browse/MESOS-3681 > https://issues.apache.org/jira/browse/MESOS-3682 > https://issues.apache.org/jira/browse/MESOS-3684 > > > Repository: mesos > > > Description > ------- > > Agent: Add Windows support to the containerizer. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad > src/slave/containerizer/external_containerizer.cpp > cf4384cce44172a028c890f52f71ceb8ae109383 > src/slave/containerizer/fetcher.cpp > 176d8863d1becd8864218a0012ab45c614f0ad77 > src/slave/containerizer/mesos/containerizer.cpp > b154587628a5bf4b1366dbd7a281177e6aa6eb57 > src/slave/containerizer/mesos/launcher.hpp > 5977c30c0aacc569019f7b34bb0c6577823ec887 > src/slave/containerizer/mesos/launcher.cpp > a5c8c31b72773d0bd10b9d02675a01f1d641d41c > > Diff: https://reviews.apache.org/r/47576/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
