----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/#review135620 -----------------------------------------------------------
Can you please also update BROWSE_HELP, etc. with an `AUTHORIZATION(...)` string? This will also require you to run the script to update the endpoints help pages. - "Modifies the file `acls.proto`" seems wrong, since you're only modifying `authorization.md`. docs/authorization.md (line 132) <https://reviews.apache.org/r/48048/#comment200654> s/An user/A user/. English is weird. We don't use `an` here, because it's pronounced `a yuser`. We only put `an` in front of a word that starts with a vowel /sound/. Consider also `an honor`. - Adam B On May 30, 2016, 11:23 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48048/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 11:23 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Michael Park. > > > Bugs: MESOS-5153 > https://issues.apache.org/jira/browse/MESOS-5153 > > > Repository: mesos > > > Description > ------- > > Modifies the file `acls.proto` to take into consideration the added > authorization actions `access_sandboxes` and `access_mesos_logs`. > > > Diffs > ----- > > docs/authorization.md 723d98c859bef04448b105905443d5e7beaa968c > > Diff: https://reviews.apache.org/r/48048/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Rojas > >
