----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/#review135679 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_authorization_tests.cpp (line 1170) <https://reviews.apache.org/r/48054/#comment200683> s/with/with the/ s/view/view the/ src/tests/master_authorization_tests.cpp (line 1191) <https://reviews.apache.org/r/48054/#comment200684> s/with/with the/ s/view/view the/ src/tests/master_authorization_tests.cpp (line 1227) <https://reviews.apache.org/r/48054/#comment200686> /state ?? src/tests/master_authorization_tests.cpp (line 1231) <https://reviews.apache.org/r/48054/#comment200685> s/can/can see/ src/tests/master_authorization_tests.cpp (line 1252) <https://reviews.apache.org/r/48054/#comment200687> s/can/can see/ src/tests/master_authorization_tests.cpp (line 1273) <https://reviews.apache.org/r/48054/#comment200688> instead of setting these "no principal can do foo" ACLs, you can just set permissive to `false`. src/tests/master_authorization_tests.cpp (line 1336) <https://reviews.apache.org/r/48054/#comment200689> What does it mean to create a task running with authorizer? Just kill this comment. src/tests/master_authorization_tests.cpp (line 1358) <https://reviews.apache.org/r/48054/#comment200690> s/user/the user/ s/view/view the/ src/tests/master_authorization_tests.cpp (line 1388) <https://reviews.apache.org/r/48054/#comment200691> the user, the framework, the executor. src/tests/master_authorization_tests.cpp (line 1457) <https://reviews.apache.org/r/48054/#comment200692> can see. src/tests/master_authorization_tests.cpp (line 1541) <https://reviews.apache.org/r/48054/#comment200693> ditto. src/tests/master_authorization_tests.cpp (line 1563) <https://reviews.apache.org/r/48054/#comment200694> the user the framework src/tests/master_authorization_tests.cpp (line 1582) <https://reviews.apache.org/r/48054/#comment200695> the user the frameworks the tasks - Vinod Kone On May 31, 2016, 4:24 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48054/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 4:24 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-5339 > https://issues.apache.org/jira/browse/MESOS-5339 > > > Repository: mesos > > > Description > ------- > > Added intergration tests for authorization based endpoint filtering. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > 5c221f059585d49bcccce5848bc0b655adab6b02 > > Diff: https://reviews.apache.org/r/48054/diff/ > > > Testing > ------- > > make check (OSx) > + 100x repeat on new tests. > > > Thanks, > > Joerg Schad > >
