----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review135736 -----------------------------------------------------------
Patch looks great! Reviews applied: [48094] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 31, 2016, 9:37 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48094/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 9:37 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5494 > https://issues.apache.org/jira/browse/MESOS-5494 > > > Repository: mesos > > > Description > ------- > > Implemented GET_ROLES Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master.proto bcbdd4308ab1963289f59edc8c3cd7695afa72ab > src/internal/evolve.cpp 4f25f1a892b4834fc4d79b6fd1bd0edd458b7a58 > src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 > src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 > src/tests/api_tests.cpp 0b6bfadae3a969b3cd1a48e5095e64c953193543 > > Diff: https://reviews.apache.org/r/48094/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > > sudo GTEST_FILTER="MasterAPITest.*" make -j2 check > > > Thanks, > > Abhishek Dasgupta > >
