----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47932/#review136195 -----------------------------------------------------------
3rdparty/stout/3rdparty/Makefile.am (lines 1 - 15) <https://reviews.apache.org/r/47932/#comment201208> This is the wrong header, all stout and libprocess related files must contain the "Apache License Version 2.0" header. ``` # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License ``` 3rdparty/stout/3rdparty/Makefile.am (line 45) <https://reviews.apache.org/r/47932/#comment201206> +1 3rdparty/stout/3rdparty/Makefile.am (line 123) <https://reviews.apache.org/r/47932/#comment201207> Can we please have the backslashes aligned here? 3rdparty/stout/3rdparty/gmock_sources.cc.in (lines 2 - 12) <https://reviews.apache.org/r/47932/#comment201209> Wrong header again, use the "Apache License Version 2.0" header instead. - Till Toenshoff On May 26, 2016, 11:30 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47932/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 11:30 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-5416 > https://issues.apache.org/jira/browse/MESOS-5416 > > > Repository: mesos > > > Description > ------- > > Stout: made standalone build work again. > > > Diffs > ----- > > 3rdparty/stout/3rdparty/Makefile.am PRE-CREATION > 3rdparty/stout/3rdparty/gmock_sources.cc.in PRE-CREATION > 3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 > 3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 > > Diff: https://reviews.apache.org/r/47932/diff/ > > > Testing > ------- > > The following passes from within 3rdparty/stout: > ./bootstrap && mkdir build && cd build && ../configure && make check > > > Thanks, > > Kapil Arya > >
