----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48244/#review136200 -----------------------------------------------------------
Ship it! - Till Toenshoff On June 4, 2016, 2:29 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48244/ > ----------------------------------------------------------- > > (Updated June 4, 2016, 2:29 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-5540 > https://issues.apache.org/jira/browse/MESOS-5540 > > > Repository: mesos > > > Description > ------- > > This functionality relied on the `getfsent` family of functions, > which are not portable (e.g., they are not implemented by musl). > These functions are not thread-safe, and we don't actually use > this functionality in Mesos anyway. > > > Diffs > ----- > > src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 > src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd > src/tests/containerizer/fs_tests.cpp > 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 > support/docker_build.sh 058b982d1a9ab5ac624d023fb1a1054128157083 > > Diff: https://reviews.apache.org/r/48244/diff/ > > > Testing > ------- > > Successful compilation with Alpine Linux 3.3.3; also tested that the build > continues to work on OSX and various supported Linux distributions (CentOS, > Fedora, Debian, Ubuntu). > > > Thanks, > > Neil Conway > >
