----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136286 -----------------------------------------------------------
src/master/http.cpp (line 2773) <https://reviews.apache.org/r/48116/#comment201304> this should return `v1::master::Response`. see below comment. src/master/http.cpp (lines 2904 - 2907) <https://reviews.apache.org/r/48116/#comment201306> shouldn't need to do this if `_updateMaintenanceSchedule` returns v1::master::Response. src/master/http.cpp (line 2914) <https://reviews.apache.org/r/48116/#comment201303> why want this function to return `v1::master::Response` instead of `http::Response` to be consistent with how we did for others. since this response doesn't have a body, this could be an empty `v1::master::Response`. - Vinod Kone On June 5, 2016, 6 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48116/ > ----------------------------------------------------------- > > (Updated June 5, 2016, 6 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5505 > https://issues.apache.org/jira/browse/MESOS-5505 > > > Repository: mesos > > > Description > ------- > > Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/master/http.cpp 4fbf5638fb9ae8e7b28c21529d15735e46a85ffb > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > > Diff: https://reviews.apache.org/r/48116/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
