----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47807/#review136356 -----------------------------------------------------------
src/docker/spec.cpp (line 196) <https://reviews.apache.org/r/47807/#comment201375> `parseConfig` src/docker/spec.cpp (line 197) <https://reviews.apache.org/r/47807/#comment201379> Why optional? If the config file is not there. Can we just not call this function? So this function should return a Try therefore. src/docker/spec.cpp (line 203) <https://reviews.apache.org/r/47807/#comment201380> Can you make a comment in this function that it handles both old and new docker config format? src/docker/spec.cpp (line 220) <https://reviews.apache.org/r/47807/#comment201381> Do you need this temp variable? - Jie Yu On May 25, 2016, 1:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47807/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 1:33 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented parsing a docker config to a hashmap. > > > Diffs > ----- > > include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 > src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d > > Diff: https://reviews.apache.org/r/47807/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
