----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review136542 -----------------------------------------------------------
src/examples/balloon_framework.cpp (lines 53 - 58) <https://reviews.apache.org/r/45604/#comment201603> don't need to do this anymore. flags now support required without default! src/examples/balloon_framework.cpp (lines 66 - 69) <https://reviews.apache.org/r/45604/#comment201604> see above. don't need this. src/examples/balloon_framework.cpp (lines 84 - 89) <https://reviews.apache.org/r/45604/#comment201605> ditto. src/examples/balloon_framework.cpp (lines 119 - 121) <https://reviews.apache.org/r/45604/#comment201606> These need not be Option anymore. src/examples/balloon_framework.cpp (line 183) <https://reviews.apache.org/r/45604/#comment201608> // If there is an active task, or ... - Vinod Kone On June 6, 2016, 11:55 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45604/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 11:55 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > This gives the example `balloon-framework` enough options to run > outside of the build environment: > > * Adds an option for restricting the number of resources per task > (otherwise, it will eat up an entire node). > * Adds an option for persisting the framework and launching one task > after another. > * Adds filters for declined offers. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 > src/tests/balloon_framework_test.sh > a242f6cb9ca1850e5fef90e0938f41044bdaddbf > > Diff: https://reviews.apache.org/r/45604/diff/ > > > Testing > ------- > > ``` > make check > > sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework" > ``` > > > Thanks, > > Joseph Wu > >
