-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48364/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-5550
https://issues.apache.org/jira/browse/MESOS-5550
Repository: mesos
Description
-------
We now use a singleton class called `NvidiaManagementLibrary` that
loads `libnvidia-ml` at runtime once it is initialized. By loading
this library dynamically, `libmesos` no longer has a hard dependence
on it, so it doesn't have to be installed on every machine where mesos
is deployed.
This was a problem previously, whereby the master and agents that
didn't even have GPUs would unnecessarily need to have `libnvidia-ml`
installed on their systems. This library is not easily installable
(it's not bundled in standard apt-get or yum repositories), so this
was a major inconvenience.
Diffs
-----
configure.ac e344c56e1be5e232ee331c933b8c04c4c2e55d1e
src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b
src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp
f290e3c1d1114698039a505e972793dc325c7100
src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp
7849e518af448d9557ca4d6de4ccaba8bc572992
src/slave/containerizer/mesos/isolators/gpu/nvml.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/nvml.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/48364/diff/
Testing
-------
GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
Thanks,
Kevin Klues
