----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48370/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Bugs: MESOS-5556 https://issues.apache.org/jira/browse/MESOS-5556 Repository: mesos Description ------- Previously, the major/minor numbers of `/dev/nvidiactl` and `/dev/nvidia-uvm` were hard-coded. This actually caused problems for `/dev/nvidia-uvm` because its major number is part of the "Experimental" device range on Linux. Because this range is experimental, there is no guarantee which device number will be assigned to it on a given machine. We actually encountered this problem in the wild, prompting this change. We now use `os:stat::rdev()` to extract the major/minor numbers programatically. Diffs ----- src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp f290e3c1d1114698039a505e972793dc325c7100 src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992 Diff: https://reviews.apache.org/r/48370/diff/ Testing ------- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues