----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48427/ -----------------------------------------------------------
Review request for mesos and Jie Yu. Repository: mesos Description ------- This is a stop-gap for issuing a kill on the stale healthPid. However, there are additional issues with this code. Namely, we do not reap the healthPid and so if it terminates we may still try to kill a stale pid. Also, we do not kill the health process upon finalizing the executor, we should consider adding a finalize that performs the necessary cleanup. Lastly, there are a number of other bugs and structural issues in the health checking code, and so I've punted on doing more major changes here in favor of at least fixing this glaring bug. Diffs ----- src/docker/executor.cpp 1b3a7795b1db83394d4b884c1041c341f88a7df1 src/launcher/executor.cpp ffebb3a496be6a20396f8f539372a1e7527c9b6d Diff: https://reviews.apache.org/r/48427/diff/ Testing ------- make check Thanks, Benjamin Mahler
