----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48437/#review136707 -----------------------------------------------------------
src/internal/evolve.cpp (line 173) <https://reviews.apache.org/r/48437/#comment201821> Can you add a TODO to have the master pass the heartbeat interval to the evolve function? Seems a bit unfortunate that evolve.cpp knows about master's logic. - Vinod Kone On June 8, 2016, 6:31 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48437/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 6:31 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5567 > https://issues.apache.org/jira/browse/MESOS-5567 > > > Repository: mesos > > > Description > ------- > > This changes modifies the `evolve` function to pass around > the heartbeat interval info. This might need some tinkering > if we decide to make heartbeat interval configurable in the > near future. > > > Diffs > ----- > > src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 > src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c > > Diff: https://reviews.apache.org/r/48437/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
