> On June 8, 2016, 6:49 p.m., Jie Yu wrote: > > In the future, please split the patch into two: 1) fix the compile issue; > > 2) do the re-ordering. As you can tell by looking at the diff, it is very > > difficult for reviewers to review. If you were to have two patches, it > > could be very simple.
Thanks for the tip. Do you mean i should create a first patch that keeps aufs test where it is and adds the `__linux__` guards around it, and then do the reording in the second patch? That surely would make the first patch easy to reason about, but still the diff of the second patch would look exactly the same as this RR (indeed, there is only reordering in this RR). - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48388/#review136674 ----------------------------------------------------------- On June 8, 2016, 2:34 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48388/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 2:34 a.m.) > > > Review request for mesos, Guangya Liu and Jie Yu. > > > Bugs: MESOS-4672 > https://issues.apache.org/jira/browse/MESOS-4672 > > > Repository: mesos > > > Description > ------- > > Fixed compilation on OS X of aufs tests. > > > Diffs > ----- > > src/tests/containerizer/provisioner_backend_tests.cpp > f18cc3f72afbefa8b4b90e77deff0874808c648a > > Diff: https://reviews.apache.org/r/48388/diff/ > > > Testing > ------- > > make check on both ubuntu 14.04 & mac osx > > > Thanks, > > Shuai Lin > >
