> On June 7, 2016, 2:11 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 52-53 > > <https://reviews.apache.org/r/48299/diff/1/?file=1407782#file1407782line52> > > > > IIRC for constructors we use the format on the left.
I think both are acceptable, but the code-base prefers this style. i.e. https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L369-L384 - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48299/#review136540 ----------------------------------------------------------- On June 9, 2016, 4:09 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48299/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 4:09 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > Changes some whitespace for the balloon framework and > changes most logging messages to use glog. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 > > Diff: https://reviews.apache.org/r/48299/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
