> On June 12, 2016, 3:35 a.m., haosdent huang wrote: > > src/common/values.cpp, line 310 > > <https://reviews.apache.org/r/48593/diff/1/?file=1415740#file1415740line310> > > > > Usually we perfer to return `Value::Ranges` directly. > > ``` > > Value::Ranges IntervalSet2Ranges(const IntervalSet<int>& set) > > ``` > > > > In additional, `convertToRanges` maybe a better name
Yes, that is better. Will change. > On June 12, 2016, 3:35 a.m., haosdent huang wrote: > > src/common/values.cpp, line 313 > > <https://reviews.apache.org/r/48593/diff/1/?file=1415740#file1415740line313> > > > > I think we could use foreach here? Thanks, will change. - Yanyan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137147 ----------------------------------------------------------- On June 12, 2016, 3:28 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 3:28 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
