----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48594/#review137161 -----------------------------------------------------------
Ship it! Please update the testing description with the updated results from a clean install. Also, if you don't mind adding another patch to this PR for always passing `--prefix=/` when configuring 3rdparty bundled software, that would be great! - Kapil Arya On June 12, 2016, 12:53 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48594/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 12:53 a.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-5577 > https://issues.apache.org/jira/browse/MESOS-5577 > > > Repository: mesos > > > Description > ------- > > Modules that want to use the `State` API for storing information in > the replicated log require zookeeper client headers. With this change > the bundled zookeeper client headers will be installed along with the > Mesos libraries and headers under the Mesos installation path. > > > Diffs > ----- > > 3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067 > > Diff: https://reviews.apache.org/r/48594/diff/ > > > Testing > ------- > > make and make install > > After running make install made sure that the bundled client libraries are > installed under the $MESOS_INSTALL path. Here is an example output: > > vagrant@mesos-dev:~/mesos_install$ find ./ -name "zookeeper*" > ./lib/mesos/3rdparty/home/vagrant/mesos_install/include/zookeeper > ./lib/mesos/3rdparty/home/vagrant/mesos_install/include/zookeeper/zookeeper.h > ./lib/mesos/3rdparty/home/vagrant/mesos_install/include/zookeeper/zookeeper_version.h > ./lib/mesos/3rdparty/home/vagrant/mesos_install/include/zookeeper/zookeeper_log.h > ./lib/mesos/3rdparty/home/vagrant/mesos_install/include/zookeeper/zookeeper.jute.h > ./include/mesos/zookeeper > ./include/mesos/zookeeper/zookeeper.hpp > ./include/mesos/state/zookeeper.hpp > > > Thanks, > > Avinash sridharan > >
