> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, lines 612-627 > > <https://reviews.apache.org/r/43561/diff/3/?file=1273811#file1273811line612> > > > > Should we add a benchmark here to understand the effect of now having 3 > > levels of `tokenize`? > > Is this code in any critical paths? > > Klaus Ma wrote: > This function is only uesd when parsing resources from string; it only > impacts the duration of `make check`. I'll try it and let you known the > impact.
Run `time build/src/mesos-test`, the result is almost the same :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review124545 ----------------------------------------------------------- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 10:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-4627 > https://issues.apache.org/jira/browse/MESOS-4627 > > > Repository: mesos > > > Description > ------- > > Improve Ranges parsing to handle single values. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/43561/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER=~"*" > ./src/mesos-test > > > Thanks, > > Klaus Ma > >
