> On June 8, 2016, 1:11 p.m., Neil Conway wrote: > > 3rdparty/stout/tests/os/rmdir_tests.cpp, line 62 > > <https://reviews.apache.org/r/48314/diff/1/?file=1408172#file1408172line62> > > > > Seems redundant to check both `listfiles` and `os::empty`, here and > > elsewhere. > > Anindya Sinha wrote: > Yes, but added os::empty() to cover testing for this newly added api.
Sure -- I'd remove the calls `listfiles` in that case. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/#review136631 ----------------------------------------------------------- On June 9, 2016, 12:24 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48314/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 12:24 a.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > Added os::empty(path) to check if contents in a directory is empty. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 > 3rdparty/stout/include/stout/os.hpp > 53b00932693fba7cf6514da6a519269a904de345 > 3rdparty/stout/include/stout/os/empty.hpp PRE-CREATION > 3rdparty/stout/tests/os/rmdir_tests.cpp > a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f > > Diff: https://reviews.apache.org/r/48314/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
