----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review137383 -----------------------------------------------------------
Fix it, then Ship it! LGTM! src/master/http.cpp (line 2864) <https://reviews.apache.org/r/48116/#comment202523> Do we want to standardize this return code (200 -> 202)? From the design doc, it seemed like empty responses should be handled with a 202. Feel free to drop this is not an issue. - Joseph Wu On June 12, 2016, 10:46 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48116/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 10:46 a.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-5505 > https://issues.apache.org/jira/browse/MESOS-5505 > > > Repository: mesos > > > Description > ------- > > Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e > src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb > > Diff: https://reviews.apache.org/r/48116/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
