----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48662/#review137396 -----------------------------------------------------------
Ship it! Let's commit this patch now as the current master branch is broken. However, the existing code does not allow operators to specify the ordering between built-in isolators and module isolators because built-in isolators always take precedence. Can you leave a TODO here to address it later? - Jie Yu On June 13, 2016, 9:12 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48662/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 9:12 p.m.) > > > Review request for mesos, Jie Yu and Kevin Klues. > > > Bugs: MESOS-5581 > https://issues.apache.org/jira/browse/MESOS-5581 > > > Repository: mesos > > > Description > ------- > > While refactoring the isolator creation in 6fb9c024, we introduced a > regression in that isolator modules were no longer being created via > the --isolation flag values. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 92c9898fb41ca0ffbda05e53b595b05c96f4f596 > > Diff: https://reviews.apache.org/r/48662/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Benjamin Mahler > >
