----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review137407 -----------------------------------------------------------
src/master/validation.cpp (line 308) <https://reviews.apache.org/r/48614/#comment202537> `uuid` is a required field so don't need to do the if check here. after addressing the previous comments this should be, ``` Try<UUID> uuid = UUID::fromBytes(call.acknowledge.uuid()); if (uuid.isError()) { return Error("Invalid UUID: " + uuid.error()); } ``` src/slave/validation.cpp (line 148) <https://reviews.apache.org/r/48614/#comment202538> if blocks have "{" on the same line as the if statement. see above. ``` Try<UUID> uuid = UUID::fromBytes(status.uuid()); if (uuid.isError()) { return Error("Invalid UUID: " + uuid.error()); } ``` - Vinod Kone On June 13, 2016, 6:51 a.m., Deshna Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48614/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 6:51 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5224 > https://issues.apache.org/jira/browse/MESOS-5224 > > > Repository: mesos > > > Description > ------- > > This change adds logic to the master/agent validation helpers > to see if the status update acknowledgments have a valid UUID > set conforming to one of the supported versions. > > > Diffs > ----- > > src/master/validation.cpp 309fbed81c9ff0ccc4ff4ee3ee70cf8f1fb2ac55 > src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a > src/tests/scheduler_http_api_tests.cpp > c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 > > Diff: https://reviews.apache.org/r/48614/diff/ > > > Testing > ------- > > > Thanks, > > Deshna Jain > >
