----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48669/#review137433 -----------------------------------------------------------
3rdparty/stout/tests/os_tests.cpp (line 685) <https://reviews.apache.org/r/48669/#comment202557> Since you need root, consider making this a separate test using the "ROOT_" filter. 3rdparty/stout/tests/os_tests.cpp (line 689) <https://reviews.apache.org/r/48669/#comment202559> In general, this kind of stuff is hard to validate in unit tests. Ideally you would find a user account with > 16 groups, then create a resource that only allows access to the high groups and verify that you have access when you impersonate that use. That's pretty involved, so just mentioning it for the future :) - James Peach On June 13, 2016, 11:51 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48669/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 11:51 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > This test verifies 'setuid', 'setgid', 'getgrouplist' and > 'setgroups' work properly on both linux and os x. > > > Diffs > ----- > > 3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 > > Diff: https://reviews.apache.org/r/48669/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
