----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137464 -----------------------------------------------------------
Fix it, then Ship it! This is great! Thanks, Guangya! docs/docker-volume.md (lines 28 - 31) <https://reviews.apache.org/r/47511/#comment202605> The integration of external storage in Mesos is an attractive feature, since it supports stateful services in mesos containers by using external volumes. docs/docker-volume.md (line 35) <https://reviews.apache.org/r/47511/#comment202606> "size-limited"? docs/docker-volume.md (line 37) <https://reviews.apache.org/r/47511/#comment202607> s/is/becomes/g docs/docker-volume.md (line 88) <https://reviews.apache.org/r/47511/#comment202609> remove "to be" docs/docker-volume.md (line 89) <https://reviews.apache.org/r/47511/#comment202612> generates docs/docker-volume.md (line 95) <https://reviews.apache.org/r/47511/#comment202613> Replace "The cleanup module" by "The isolator cleanup"? docs/docker-volume.md (line 159) <https://reviews.apache.org/r/47511/#comment202614> should we kill this line? (I would suggest for here in doc). docs/docker-volume.md (line 165) <https://reviews.apache.org/r/47511/#comment202615> ditto. docs/docker-volume.md (line 167) <https://reviews.apache.org/r/47511/#comment202616> ditto. docs/docker-volume.md (line 172) <https://reviews.apache.org/r/47511/#comment202617> ditto. docs/docker-volume.md (lines 306 - 311) <https://reviews.apache.org/r/47511/#comment202618> It is highly not recommended to use the same Docker volume by DockerContainerizer and MesosContainerizer simultaneously, because MesosContainerizer has its own reference counter to decide when to unmount the Docker volume mount point. Otherwise, it would be problematic if a Docker volume is unmounted by MesosContainerizer but the DockerContainerizer is still using it. - Gilbert Song On June 12, 2016, 8:18 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47511/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 8:18 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5216 > https://issues.apache.org/jira/browse/MESOS-5216 > > > Repository: mesos > > > Description > ------- > > Added documentation for `docker/volume` isolator. > > > Diffs > ----- > > docs/docker-volume.md PRE-CREATION > docs/images/docker-volume-isolator.png PRE-CREATION > > Diff: https://reviews.apache.org/r/47511/diff/ > > > Testing > ------- > > You can review the document here: > https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md > > > Thanks, > > Guangya Liu > >
