----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48578/#review137573 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On June 11, 2016, 3:03 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48578/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 3:03 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5582 > https://issues.apache.org/jira/browse/MESOS-5582 > > > Repository: mesos > > > Description > ------- > > In a previous commit, the `cgroups/devices` isolator was abstracted > out of the Nvidia GPU isolator. However, the code for destroying the > devices susbsystem wasn't removed from the GPU isolator, causing it to > "double destroy" the subsystem upon cleanup. This commit removed this > redundant code. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp > 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7 > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp > d7557a0c338e8c0e51461b2326600c03f89c2e8b > > Diff: https://reviews.apache.org/r/48578/diff/ > > > Testing > ------- > > make -j > GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
