----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48601/#review137604 -----------------------------------------------------------
3rdparty/libprocess/src/metrics/metrics.cpp (lines 251 - 279) <https://reviews.apache.org/r/48601/#comment202794> This induces a performance regression to /metrics/snapshot REST endpoint! See https://reviews.apache.org/r/48046/ for inspiration on how to refactor methods that use JSON::ObjectWriter. - Vinod Kone On June 12, 2016, 6:03 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48601/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 6:03 p.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, and Vinod Kone. > > > Bugs: MESOS-5484 > https://issues.apache.org/jira/browse/MESOS-5484 > > > Repository: mesos > > > Description > ------- > > Exposed metrics information via `process::metrics::snapshot`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 25e8fcaeb9c71eaa43096165745e79c8198c139a > 3rdparty/libprocess/src/metrics/metrics.cpp > be03406c58439b7ab7c1ba12c19dd9f30aff109e > > Diff: https://reviews.apache.org/r/48601/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
