----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/#review137686 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/executor.cpp (lines 78 - 82) <https://reviews.apache.org/r/47603/#comment202912> If you do this in `launcher/executor.hpp`, then why do it again here? src/launcher/executor.cpp (line 160) <https://reviews.apache.org/r/47603/#comment202878> brace on new line src/launcher/executor.cpp (line 162) <https://reviews.apache.org/r/47603/#comment202879> indentation src/launcher/executor.cpp (line 166) <https://reviews.apache.org/r/47603/#comment202880> brace on new line src/launcher/executor.cpp (lines 172 - 173) <https://reviews.apache.org/r/47603/#comment202881> space between functions src/launcher/executor.cpp (line 402) <https://reviews.apache.org/r/47603/#comment202893> typo. src/launcher/executor.cpp (line 405) <https://reviews.apache.org/r/47603/#comment202896> please use full names `processInformation` src/launcher/executor.cpp (line 406) <https://reviews.apache.org/r/47603/#comment202894> indentation src/launcher/executor.cpp (line 407) <https://reviews.apache.org/r/47603/#comment202895> new line. src/launcher/posix/executor.hpp (lines 26 - 30) <https://reviews.apache.org/r/47603/#comment202897> You CAN NOT do this in header files. src/launcher/posix/executor.hpp (lines 36 - 42) <https://reviews.apache.org/r/47603/#comment202899> I asked to have cpp files made for these. What happened? src/launcher/posix/executor.hpp (lines 37 - 38) <https://reviews.apache.org/r/47603/#comment202911> Where are the includes for these? src/launcher/posix/executor.hpp (lines 49 - 54) <https://reviews.apache.org/r/47603/#comment202882> Please make changes like this separate patches next time. src/launcher/posix/executor.hpp (line 52) <https://reviews.apache.org/r/47603/#comment202883> missing `:` after error description. src/launcher/posix/executor.hpp (line 94) <https://reviews.apache.org/r/47603/#comment202885> Please be careful when rebasing. You copied your old code instead of adjusting to the new pattern for the conflict. `NULL` -> `nullptr` src/launcher/posix/executor.hpp (line 96) <https://reviews.apache.org/r/47603/#comment202886> nullptr src/launcher/posix/executor.hpp (line 150) <https://reviews.apache.org/r/47603/#comment202913> Where are you sourcing `user` from now that you're no longer in the executor object's scope? Did you try compiling this at all? src/launcher/posix/executor.hpp (line 164) <https://reviews.apache.org/r/47603/#comment202888> indentation. double semicolon. src/launcher/posix/executor.hpp (line 170) <https://reviews.apache.org/r/47603/#comment202914> Where are you sourcing `workingDirectory` from now that you're no longer in the executor object's scope? Did you try compiling this at all? src/launcher/posix/executor.hpp (line 174) <https://reviews.apache.org/r/47603/#comment202915> Where are you sourcing `sandboxDirectory` from now that you're no longer in the executor object's scope? Did you try compiling this at all? src/launcher/posix/executor.hpp (line 180) <https://reviews.apache.org/r/47603/#comment202889> indentation. src/launcher/posix/executor.hpp (line 188) <https://reviews.apache.org/r/47603/#comment202890> indentation. src/launcher/posix/executor.hpp (line 207) <https://reviews.apache.org/r/47603/#comment202892> Why are you changing this behavior? This is very dangerous to do during a code move. The original code uses `command` not `task.command`. src/launcher/posix/executor.hpp (line 208) <https://reviews.apache.org/r/47603/#comment202887> nullptr src/launcher/posix/executor.hpp (line 227) <https://reviews.apache.org/r/47603/#comment202891> indentation. src/launcher/windows/executor.hpp (lines 38 - 43) <https://reviews.apache.org/r/47603/#comment202901> Same here. What happened to the cpp file we discussed? src/launcher/windows/executor.hpp (line 53) <https://reviews.apache.org/r/47603/#comment202902> Same as above. Why are you using `task.command()` instead of `command`? The old code did not do this. src/launcher/windows/executor.hpp (lines 70 - 71) <https://reviews.apache.org/r/47603/#comment202903> formatting src/launcher/windows/executor.hpp (lines 72 - 73) <https://reviews.apache.org/r/47603/#comment202904> else goes on same line as closing brace src/launcher/windows/executor.hpp (lines 78 - 79) <https://reviews.apache.org/r/47603/#comment202905> else goes on same line as closing brace src/launcher/windows/executor.hpp (lines 89 - 96) <https://reviews.apache.org/r/47603/#comment202906> nullptr src/launcher/windows/executor.hpp (line 90) <https://reviews.apache.org/r/47603/#comment202907> space after c-style casts src/launcher/windows/executor.hpp (line 101) <https://reviews.apache.org/r/47603/#comment202908> why cout instead of cerr? src/launcher/windows/executor.hpp (lines 101 - 102) <https://reviews.apache.org/r/47603/#comment202909> wrapping src/launcher/windows/executor.hpp (line 111) <https://reviews.apache.org/r/47603/#comment202910> indentation - Joris Van Remoortere On June 8, 2016, 4:20 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47603/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 4:20 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Agent:[2/2] Added Windows support for folder `launcher/`. > > > Diffs > ----- > > src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b > src/exec/exec.cpp 15ebb7416701cea7f83adf178d1b56a5c6901102 > src/launcher/executor.hpp PRE-CREATION > src/launcher/executor.cpp ffebb3a496be6a20396f8f539372a1e7527c9b6d > src/launcher/posix/executor.hpp PRE-CREATION > src/launcher/windows/executor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/47603/diff/ > > > Testing > ------- > > OSX: make check > > > Thanks, > > Alex Clemmer > >
